object_store: Add enabled-by-default "fs" feature #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @tustvold |
tustvold
added
api-change
|
I had a quick look and this looks plausible, however, it is a breaking change and will therefore need to wait for the next major release |
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
799e4cf
to
77c3931
Compare
alamb
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Makes sense to me. Thank you @Turbo87
Could you also please add a test for clippy here:
Specifically these two combinations?
--no-deafult-features--no-default-features --features fs?
Turbo87
force-pushed
the
object_store/optional-fs
branch
from
77c3931
to
5efbd80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6055.
Rationale for this change
see #6055 😉
What changes are included in this PR?
This PR introduces a new
fsfeature for theobject_storecrate, which is enabled by default. If disabled, thelocalmodule is excluded from the crate and thewalkdirdependency is skipped.Are there any user-facing changes?
Only for users of
default-features = false, but since this crate did not have any default features before there probably won't be manyobject_storeusers that specifydefault-features = false.